Fix image display for dark mode on Instrumentation Scope page #5438 #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o customize-visualizations Update the branch EXIT
…opentelemetry.io into customize-visualizations
opentelemetrybot
requested review from
a team and
TylerHelmuth
and removed request for
a team
|
@svrnm, I have implemented the changes you recommended. Could you please take a look. |
|
@SusanGithaigaN can you make sure that this PR only updates the one image on Instrumentation Scope? Thanks |
svrnm
changed the title
svrnm
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the image colors on the Instrumentation scope page, to make the image text visible on light and dark mode.
Before:
After:
Demo
Fix.instrumentation-scope.svg.webm