[demo] rename demo services #6438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mviitane
reviewed
Feb 28, 2025
| @@ -5,7 +5,7 @@ aliases: [manual_span_attributes, ../manual-span-attributes] | |||
|
|
|||
| This page lists the manual Span Attributes used throughout the demo: | |||
|
|
|||
| ## AdService | |||
| ## Ad Service | |||
There was a problem hiding this comment.
Optional: "Service" could be removed from the headings on this page for consistency because some components, like the Load generator, are without it. This way, we wouldn't need to differentiate components that are considered services from those that aren't.
chalin
requested changes
Feb 28, 2025
| @@ -57,11 +57,11 @@ problems in distributed applications. | |||
| A PHP service should be added to the main application as an 'admin service'. A | |||
| Database should be added to enable CRUD functionality on the Product Catalog. | |||
|
|
|||
| The 'shippingservice' should be reimplemented in Rust. | |||
| The 'shipping' service should be reimplemented in Rust. | |||
There was a problem hiding this comment.
Suggested change
| The 'shipping' service should be reimplemented in Rust. | |
| The shipping service should be reimplemented in Rust. |
| @@ -57,11 +57,11 @@ problems in distributed applications. | |||
| A PHP service should be added to the main application as an 'admin service'. A | |||
There was a problem hiding this comment.
Suggested change
| A PHP service should be added to the main application as an 'admin service'. A | |
| A PHP service should be added to the main application as an admin service. A |
|
|
||
| The 'currencyservice' should be reimplemented in C++. | ||
| The 'currency' service should be reimplemented in C++. |
There was a problem hiding this comment.
Suggested change
| The 'currency' service should be reimplemented in C++. | |
| The currency service should be reimplemented in C++. |
|
|
||
| The 'emailservice' should be reimplemented in Ruby. | ||
| The 'email' service should be reimplemented in Ruby. |
There was a problem hiding this comment.
Suggested change
| The 'email' service should be reimplemented in Ruby. | |
| The email service should be reimplemented in Ruby. |
| @@ -70,11 +70,11 @@ work, and viewing the details allows us to get a better idea of what's going on. | |||
| We can see in our waterfall view that the `app.cache_hit` attribute is set to | |||
| `false`, and that the `app.products.count` value is extremely high. | |||
There was a problem hiding this comment.
Suggested change
| `false`, and that the `app.products.count` value is extremely high. | |
| false, and that the `app.products.count` value is extremely high. |
| requests tend to be faster when the cache is hit. Now search for | ||
| `app.cache_hit=false` and compare the latency. You should notice some changes in | ||
| the visualization at the top of the trace list. | ||
| Returning to the search UI, filter to `recommendation` in the Service dropdown, |
There was a problem hiding this comment.
Suggested change
| Returning to the search UI, filter to `recommendation` in the Service dropdown, | |
| Returning to the search UI, select "recommendation" in the Service dropdown, |
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| title: Accounting Service | |||
| linkTitle: Accounting | |||
| aliases: [accountingservice] | |||
| aliases: [accounting] | |||
There was a problem hiding this comment.
Aliases are "forever". This must not be renamed:
Suggested change
| aliases: [accounting] | |
| aliases: [accountingservice] |
Please revert the changes to aliases fields in this and other pages.
| corresponding `quoteservice` _server_ span. The tracing instrumentation is | ||
| implemented in the client middleware making use of the available | ||
| `reqwest-middleware`, `reqwest-tracing` and `tracing-opentelemetry` libraries: | ||
| A child _client_ span is also produced for the outgoing HTTP call to `quote` via |
There was a problem hiding this comment.
Suggested change
| A child _client_ span is also produced for the outgoing HTTP call to `quote` via | |
| A child _client_ span is also produced for the outgoing HTTP call to quote service via |
| implemented in the client middleware making use of the available | ||
| `reqwest-middleware`, `reqwest-tracing` and `tracing-opentelemetry` libraries: | ||
| A child _client_ span is also produced for the outgoing HTTP call to `quote` via | ||
| the `reqwest` client. This span pairs up with the corresponding `quote` _server_ |
There was a problem hiding this comment.
Suggested change
| the `reqwest` client. This span pairs up with the corresponding `quote` _server_ | |
| the `reqwest` client. This span pairs up with the corresponding quote service _server_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we did the demo services rename as part of this issue in the demo repo, not all references were updated in docs. This PR updates all remaining references that need to be changed.
Preview: https://deploy-preview-6438--opentelemetry.netlify.app/docs/demo/