Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev multi port traffic #316

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

anjan-keysight
Copy link
Contributor

Traffic support on multiple Rx ports.

@@ -43,10 +43,14 @@ components:
- '/components/schemas/Port/properties/name'
- '/components/schemas/Lag/properties/name'
x-field-uid: 1
rx_name:
rx_names:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks backward compatibility for all port based tests.
Some options to mitigate broken tests would be:

  • deprecate the rx_name property for a few releases and at the same time introduce rx_names
  • introduce a new choice called ports which will have rx_names

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I will keep the rx_name property in deprecated state for few releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajbalogh I have updated and retained rx_name property in deprecated state.

@anjan-keysight
Copy link
Contributor Author

The processing of get metrics response is captured here

@ashutshkumr FYI.

@anjan-keysight
Copy link
Contributor Author

@ajbalogh there had been some internal discussions whether we need the multiple Rx port support (raw traffic) in the immediate future, and it was decided we will port some of the target FP testcases to use device traffic instead (for which multiple Rx port support is already present in model). We will park this PR for the time being.

@bortok
Copy link

bortok commented May 24, 2023

@anjan-keysight @ashutshkumr let's define if this has to be settled before v1.0 release. Or put it the other way, if we mark rx_name (does it also apply to tx_name?) as deprecated at some point, do we remove it from the model on v1.0 release, or wait till v2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants