Use proper exit codes

open-vsx · Aug 21, 2023 · 9d4dffd · 9d4dffd
1 parent d8f1bf3
commit 9d4dffd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/publish-extension.js b/publish-extension.js
@@ -219,7 +219,7 @@ openGalleryApi.post = (url, data, additionalHeaders) =>
             console.log(`Published ${id} to https://${registryHost}/extension/${id.split(".")[0]}/${id.split(".")[1]}`);
         } else {
             console.error("The OVSX_PAT environment variable was not provided, which means the extension cannot be published. Provide it or set SKIP_PUBLISH to true to avoid seeing this.");
-            process.exitCode = -1;
+            process.exitCode = 1;
         }
 
     } catch (error) {
@@ -229,7 +229,7 @@ openGalleryApi.post = (url, data, additionalHeaders) =>
         } else {
             console.error(`[FAIL] Could not process extension: ${JSON.stringify({ extension, context }, null, 2)}`);
             console.error(error);
-            process.exitCode = -1;
+            process.exitCode = 1;
         }
     }
 })();
diff --git a/report-extensions.js b/report-extensions.js
@@ -196,7 +196,7 @@ const generateOpenVsxLink = (/** @type {string} */ id) => `[${id}](https://${reg
 
     if ((unstable || stat.failed.length || outdated) && process.env.VALIDATE_PR === 'true') {
         // Fail the validating job if there are failing extensions
-        process.exitCode = -1;
+        process.exitCode = 1;
     }
 
     /**
@@ -215,7 +215,7 @@ const generateOpenVsxLink = (/** @type {string} */ id) => `[${id}](https://${reg
     // This should indicate a big extension breaking
     if (existsFailingExtensionAboveThreshold) {
         console.error(`There are outdated extensions above the threshold of ${humanNumber(threshold)} installs. See above for the list.`);
-        process.exitCode = -1;
+        process.exitCode = 1;
     }
 
     if (msPublished) {