feat(poc): e2e test with extension system #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
indirection42
commented
Jun 17, 2024
•
indirection42
commented
- Modify core extension and fungibles extension
- Modify poc runtime to use extension system
indirection42
changed the title
xlc
approved these changes
Jun 18, 2024
poc/extensions/src/lib.rs
Outdated
| let call_bytes = caller | ||
| .read_memory_into_vec(call_ptr, call_len) | ||
| .map_err(|_| ExtensionError::PolkavmError)?; | ||
| if P::is_allowed(extension_id, &call_bytes, invoke_source) { | ||
| #[cfg(feature = "std")] | ||
| println!( |
There was a problem hiding this comment.
use log crate for logging. e.g. log::info!("...")
poc/runtime/Cargo.toml
Outdated
| pallet-timestamp = { version = "30.0.0", default-features = false } | ||
| pallet-transaction-payment = { version = "31.0.0", default-features = false } | ||
| pallet-transaction-payment-rpc-runtime-api = { version = "31.0.0", default-features = false } | ||
| pallet-balances = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.10.0", default-features = false } |
There was a problem hiding this comment.
At first, I added the pallet_assets, but I didn't find the proper version to make it compatible with other pallets. The compiler told me some deps have two versions. So, I think it would be easy to use same git version tag to conform compatibility.
There was a problem hiding this comment.
yeah that's annoying. use this to set the versions https://github.com/paritytech/psvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.