fix: release idle connection when client close #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuthus5
force-pushed
the
fix/http_client
branch
from
b04a5b1 to
eb10113
Compare
hezhangjian
reviewed
Dec 30, 2024
Signed-off-by: Young Xu <[email protected]>
xuthus5
force-pushed
the
fix/http_client
branch
from
eb10113 to
98e0a44
Compare
|
is that to fix #210 ?? |
yes！ |
hezhangjian
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #210
The server decides when to close the HTTP long connection, which is determined by the
ReadTimeout,ReadHeaderTimeout, andIdleTimeoutofhttp.Server. Currently, opengeminits-sqldoes not configure these three values, which means that if the client process does not exit, the server will always keep the TCP connection KeepAlive.