feat: implement point codec #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chenxulin97
force-pushed
the
write
branch
2 times, most recently
from
7bc5be5 to
f0b7aa6
Compare
hezhangjian
reviewed
Dec 4, 2023
opengemini/point.go
Outdated
| Time time.Time | ||
| Tags map[string]string | ||
| Fields map[string]interface{} | ||
| //Timestamp precision ,default value is PrecisionNanoSecond |
There was a problem hiding this comment.
Suggested change
| //Timestamp precision ,default value is PrecisionNanoSecond | |
| // Precision Timestamp precision ,default value is PrecisionNanoSecond |
hezhangjian
reviewed
Dec 4, 2023
opengemini/point.go
Outdated
| p.Precision = precision | ||
| } | ||
|
|
||
| func (p *Point) SetMeasurement(name string) { | ||
| p.Measurement = name | ||
| } | ||
|
|
||
| func (p *Point) String() string { | ||
| //return empty string if point hasn't set measurement or add field |
There was a problem hiding this comment.
I think we can remove this comment
hezhangjian
approved these changes
Dec 4, 2023
Signed-off-by: PennyYoon <[email protected]>
hezhangjian
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.