feat: support batch points write method #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chenxulin97
force-pushed
the
write
branch
8 times, most recently
from
d28267e to
172850f
Compare
hezhangjian
reviewed
Dec 5, 2023
| @@ -17,7 +17,8 @@ type Client interface { | |||
| // Ping check that status of cluster. | |||
| Ping(idx int) error | |||
| Query(query Query) (*QueryResult, error) | |||
|
|
|||
Chenxulin97
force-pushed
the
write
branch
2 times, most recently
from
e518943 to
3890e3f
Compare
hezhangjian
reviewed
Dec 5, 2023
opengemini/write.go
Outdated
| } | ||
|
|
||
| defer resp.Body.Close() | ||
| if resp.StatusCode != 204 { |
There was a problem hiding this comment.
Suggested change
| if resp.StatusCode != 204 { | |
| if resp.StatusCode != http.StatusNoContent { |
hezhangjian
reviewed
Dec 5, 2023
opengemini/write_test.go
Outdated
| c := testDefaultClient(t) | ||
|
|
||
| // create a test database with rand suffix | ||
| var database = randomDatabaseName() |
There was a problem hiding this comment.
Suggested change
| var database = randomDatabaseName() | |
| database := randomDatabaseName() |
Signed-off-by: PennyYoon <[email protected]>
hezhangjian
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.