Skip to content

Commit

Permalink
refactor: merge client module to opengemini-client (#125)
Browse files Browse the repository at this point in the history
  • Loading branch information
ZhangJian He authored Sep 26, 2024
1 parent 7d72d09 commit 4dc8078
Show file tree
Hide file tree
Showing 22 changed files with 34 additions and 174 deletions.
37 changes: 0 additions & 37 deletions opengemini-client-asynchttpclient/pom.xml

This file was deleted.

This file was deleted.

32 changes: 0 additions & 32 deletions opengemini-client-jdk/pom.xml

This file was deleted.

This file was deleted.

17 changes: 12 additions & 5 deletions opengemini-client-okhttp/pom.xml → opengemini-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<version>0.3.0</version>
</parent>

<artifactId>opengemini-client-okhttp</artifactId>
<artifactId>opengemini-client</artifactId>

<dependencies>
<dependency>
Expand All @@ -23,15 +23,22 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>io.opengemini</groupId>
<artifactId>opengemini-client-test-common</artifactId>
<version>${project.version}</version>
<scope>test</scope>
<groupId>org.asynchttpclient</groupId>
<artifactId>async-http-client</artifactId>
<version>${async-http-client.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>${okhttp.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.opengemini</groupId>
<artifactId>opengemini-client-test-common</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
</dependencies>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,15 @@ private <T> CompletableFuture<T> compose(CompletableFuture<HttpResponse> respons
T body = JacksonService.toObject(responseBody, type);
return CompletableFuture.completedFuture(body);
} catch (JsonProcessingException e) {
return CompletableFuture.failedFuture(e);
CompletableFuture<T> future = new CompletableFuture<>();
future.completeExceptionally(e);
return future;
}
} else {
OpenGeminiException exp = new OpenGeminiException("http error: " + responseBody, responseStatus.code());
return CompletableFuture.failedFuture(exp);
CompletableFuture<T> future = new CompletableFuture<>();
future.completeExceptionally(exp);
return future;
}
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import io.opengemini.client.common.JacksonService;
import org.jetbrains.annotations.NotNull;

import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
Expand Down Expand Up @@ -98,12 +97,16 @@ protected CompletableFuture<Pong> executePing() {
T resp = JacksonService.toObject(body, type);
return CompletableFuture.completedFuture(resp);
} catch (JsonProcessingException e) {
return CompletableFuture.failedFuture(e);
CompletableFuture<T> future = new CompletableFuture<>();
future.completeExceptionally(e);
return future;
}
} else {
String errorMsg = "http error: " + body;
return CompletableFuture.failedFuture(
new OpenGeminiException(errorMsg, response.statusCode()));
OpenGeminiException openGeminiException = new OpenGeminiException(errorMsg, response.statusCode());
CompletableFuture<T> future = new CompletableFuture<>();
future.completeExceptionally(openGeminiException);
return future;
}
}

Expand All @@ -116,12 +119,6 @@ public CompletableFuture<HttpResponse> post(String url, String body) {
headers);
}

@Override
protected String encode(String str) {
// jdk17 has a better way than jdk8
return URLEncoder.encode(str, StandardCharsets.UTF_8);
}

@Override
public void close() {
// no need to close
Expand Down
4 changes: 1 addition & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@
<version>0.3.0</version>
<packaging>pom</packaging>
<modules>
<module>opengemini-client</module>
<module>opengemini-client-api</module>
<module>opengemini-client-asynchttpclient</module>
<module>opengemini-client-common</module>
<module>opengemini-client-jdk</module>
<module>opengemini-client-okhttp</module>
<module>opengemini-client-reactor</module>
<module>opengemini-client-test-common</module>
<module>spring</module>
Expand Down
7 changes: 3 additions & 4 deletions spring/opengemini-spring/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>io.opengemini</groupId>
<artifactId>opengemini-client-okhttp</artifactId>
<version>${project.version}</version>
<optional>true</optional>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>${okhttp.version}</version>
</dependency>
<dependency>
<groupId>io.opengemini</groupId>
Expand Down
5 changes: 5 additions & 0 deletions spring/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
<artifactId>opengemini-spring-parent</artifactId>
<packaging>pom</packaging>

<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
</properties>

<modules>
<module>opengemini-spring</module>
<module>opengemini-spring-boot-starter</module>
Expand Down

0 comments on commit 4dc8078

Please sign in to comment.