Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compress support #156

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: compress support #156

wants to merge 12 commits into from

Conversation

xkx9431
Copy link

@xkx9431 xkx9431 commented Jan 11, 2025 •
edited
Loading

Description

this PR is adding the compression support.

Changes

  1. add enum for compression method and content type
  2. add apply logic for modifying the http header before REST call, and process the response body according the http header config
  3. related tests

Validation

image

TodoList

  1. How should the changes for configuration be rolled out? For example, deprecate isGzipEnabled.

@xkx9431 xkx9431 changed the title @WIP feat(compress): add compress support for query response feat(compress): add compress support for query response Jan 11, 2025
@xkx9431 xkx9431 changed the title feat(compress): add compress support for query response @WIP feat(compress): add compress support for query response Jan 11, 2025
@xkx9431 xkx9431 changed the title @WIP feat(compress): add compress support for query response feat(compress): add compress support Jan 13, 2025
@xkx9431 xkx9431 changed the title feat(compress): add compress support feat: add compress support Jan 16, 2025
@xkx9431
fix(lint): build spot bugs
f6ca445 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431
feat: add test compress
48a8377 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431 xkx9431 changed the title feat: add compress support feat: compress support Jan 18, 2025
@xkx9431
fix: lint error for spotless
10ac87d 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431
fix: lint error
e6eb2d8 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431 xkx9431 changed the title feat: compress support feat: compress support Jan 18, 2025
@xkx9431
feat: add test compress
6ca11a1 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431
feat: add test compress
8f884a9 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431
feat: add test compress
b2d6ed2 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431
feat: add test compress
e0ea955 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431 xkx9431 changed the title feat: compress support @WIP feat: compress support Jan 18, 2025
@xkx9431
feat: add test compress
f99b764 
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431 xkx9431 changed the title @WIP feat: compress support feat: compress support Jan 19, 2025
@xkx9431
Copy link
Author

xkx9431 commented Jan 19, 2025 •
edited
Loading

@weiping-code @hezhangjian Please help review first.

"The tests pass consistently when configuring a single element in clientList. However, they fail randomly when using a List of clients for ParameterizedTest." Is there anything else you can help with?

@xiangyu5632
Copy link
Member

Does the server need to be configured to support data compression on the client? @xkx9431
As a result, your test cases fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xkx9431 @xiangyu5632