Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature:loan): migrated to CMP #2786

Open
wants to merge 1 commit into
base: kmp-impl
Choose a base branch
from

Conversation

Nagarjuna0033
Copy link
Contributor

@Nagarjuna0033 Nagarjuna0033 commented Feb 28, 2025

Fixes - Jira-#180

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before After

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@@ -7,6 +7,8 @@
*
* See https://github.com/openMF/mobile-mobile/blob/master/LICENSE.md
*/
@file:Suppress("ktlint:standard:property-naming")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nagarjuna0033 ,

I see that you used @file:Suppress("ktlint:standard:property-naming") at the top of the file. Just a quick note when this annotation is placed at the file level, it suppresses all property naming violations in the entire file.

As we discussed before, when I ran it with @Suppress("PropertyName")on a specific property, I didn’t receive any Spotless errors. This approach could be a better choice since it only suppresses the rule for that particular property, and in the future, if someone adds a property that doesn’t follow naming conventions, it will still trigger a warning.

If @Suppress("PropertyName") doesn’t work for you, which worked for me, then you can try @Suppress("ktlint:standard:property-naming") directly on the specific property

alias(libs.plugins.mifos.android.library.compose)
alias(libs.plugins.mifos.cmp.feature)
alias(libs.plugins.kotlin.serialization)
id(libs.plugins.kotlin.parcelize.get().pluginId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding Pacelize plugin this way is cleaner, shorter and more readable
alias(libs.plugins.kotlin.parcelize)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants