Use *at functions for directory creation #124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform path traversal manually and do not follow symlinks.
jsegitz
requested changes
Sep 24, 2024
| char *saveptr = NULL; | ||
| const char *component = strtok_r(local_path, "/", &saveptr); | ||
| while (component) { | ||
| int nextdirfd = openat(dirfd, component, O_RDONLY | O_DIRECTORY | O_NOFOLLOW); |
There was a problem hiding this comment.
I would move the error check for this right here to keep it together
| } | ||
| node_basename = node_basename + 1; // Skip / | ||
|
|
||
| // Ok to assign mode before chown? |
| fprintf(stderr, "Failed to create directory '%s': %m\n", node->dirname); | ||
| rc = 1; | ||
| continue; | ||
| } | ||
|
|
||
| if (chown(node->dirname, node->user_id, node->group_id) < 0) { | ||
| // Ok to assign ownership before se labels? |
There was a problem hiding this comment.
no, it would be better to first change the labels, then set the owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform path traversal manually and do not follow symlinks.
Draft because some TODOs still open. Also absolutely untested.