import packaging to be compatible with setuptools==70.0.0 #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 3, 2024 15:38
… supporting prior setuptools versions
This was referenced Jun 3, 2024
jongwook
reviewed
Jun 3, 2024
clip/clip.py
Outdated
| raise ImportError(f"Failed to import 'packaging' module: {e}") | ||
|
|
||
| packaging = import_packaging() | ||
|
|
There was a problem hiding this comment.
Thanks for the contribution -- looks like the function was defined twice unintentionally, could you remove the second part here?
There was a problem hiding this comment.
Nice catch thanks. I've now removed the second part, which is duplicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue #446, there is a change from setuptools 70.0.0 which causes breaking behaviour. This fix resolves this issue while maintaining backward compatibility for the import. Another option is to force usage of setuptools 70.0.0 which is provided in #449 .