[URGENT] Don't use 0 as the default mode and difficulty for Atari games #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseFarebro
changed the title
christopherhesse
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #1535 I was under the impression every game's default flavour was mode 0 difficulty 0. This turns out to not be true. There is a PR in the ALE to address this issue Farama-Foundation/Arcade-Learning-Environment#237 but for the time being it's best to just not touch the mode and difficulty if the user doesn't specify it.
Currently, a handful of games are broken as can be noted in the above PR in the ALE. These changes will solve this issue.
Hopefully, this can be acted on relatively quickly. Pinging @christopherhesse @pzhokhov