Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating deprecated alias 'np.bool8' -> 'np.bool_' #3258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gym/utils/passive_env_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,19 +222,19 @@ def env_step_passive_checker(env, action):
)
obs, reward, done, info = result

if not isinstance(done, (bool, np.bool8)):
if not isinstance(done, (bool, np.bool_)):
logger.warn(
f"Expects `done` signal to be a boolean, actual type: {type(done)}"
)
elif len(result) == 5:
obs, reward, terminated, truncated, info = result

# np.bool is actual python bool not np boolean type, therefore bool_ or bool8
if not isinstance(terminated, (bool, np.bool8)):
# np.bool is actual python bool not np boolean type, therefore bool_ or bool8 (deprecated alias)
if not isinstance(terminated, (bool, np.bool_)):
logger.warn(
f"Expects `terminated` signal to be a boolean, actual type: {type(terminated)}"
)
if not isinstance(truncated, (bool, np.bool8)):
if not isinstance(truncated, (bool, np.bool_)):
logger.warn(
f"Expects `truncated` signal to be a boolean, actual type: {type(truncated)}"
)
Expand Down