Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(azure): Add HttpRequest.Builder extension methods #9

Merged
merged 6 commits into from
Nov 21, 2024
Merged

feat(azure): Add HttpRequest.Builder extension methods #9

merged 6 commits into from
Nov 21, 2024

Conversation

mssfang
Copy link
Contributor

@mssfang mssfang commented Nov 20, 2024

Added the extension methods for

  • Azure OpenAI path segments
  • Bearer Authentication header per request for Azure Entra ID

@mssfang mssfang requested a review from a team as a code owner November 20, 2024 01:12
@RobertCraigie RobertCraigie changed the base branch from main to next November 20, 2024 10:43
@RobertCraigie
Copy link
Collaborator

@mssfang looks like there are now some merge conflicts :(

@RobertCraigie RobertCraigie changed the title [AzureOpenAI] Add HttpRequest.Builder extension methods feat(azure): Add HttpRequest.Builder extension methods Nov 20, 2024
@mssfang
Copy link
Contributor Author

mssfang commented Nov 20, 2024 •
edited
Loading

@RobertCraigie It seems like the feature branch next hasn't merged the latest changes from main branch yet, which is why the first Azure PR is missing. Would you like some help with merging the latest changes from main into next?

@TomerAberbach
Copy link
Collaborator

@RobertCraigie It seems like the feature branch next hasn't merged the latest changes from main branch yet, which is why the first Azure PR is missing. Would you like some help with merging the latest changes from main into next?

@mssfang as far as I can tell, all the branches are in sync right now. Can you clarify what you mean?

@mssfang
Copy link
Contributor Author

mssfang commented Nov 20, 2024

@RobertCraigie It seems like the feature branch next hasn't merged the latest changes from main branch yet, which is why the first Azure PR is missing. Would you like some help with merging the latest changes from main into next?

@mssfang as far as I can tell, all the branches are in sync right now. Can you clarify what you mean?

Sorry. I meant branches are missing changes from this PR

@RobertCraigie
Copy link
Collaborator

hmm it looks like some of those changes are missing in the stainless-sdks/openai-java repo as well... I'm looking into it

@RobertCraigie
Copy link
Collaborator

@mssfang okay I think the repo is in the correct state now, sorry about that! can you double check the diff in this PR? then we can merge this :)

@mssfang
Copy link
Contributor Author

mssfang commented Nov 21, 2024

@RobertCraigie Thank you. It looks correct. Let's merge it!

@RobertCraigie RobertCraigie merged commit 097c7c9 into openai:next Nov 21, 2024
2 checks passed
@RobertCraigie
Copy link
Collaborator

merged, thanks @mssfang!

@stainless-app stainless-app bot mentioned this pull request Nov 21, 2024
Merged
stainless-app bot pushed a commit that referenced this pull request Nov 21, 2024
@mssfang @RobertCraigie @stainless-app
feat(azure): Add HttpRequest.Builder extension methods (#9)
5b774cd 
* Added HttpRequest.Builder extension methods

* remove unused imports

---------

Co-authored-by: Robert Craigie <[email protected]>
@mssfang mssfang deleted the AzureOpenAI-ExtensionMethods branch November 21, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mssfang @RobertCraigie @TomerAberbach