Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectRunning() refinements #412

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

selectRunning() refinements #412

wants to merge 4 commits into from

Conversation

jack-davison
Copy link
Collaborator

This PR refines selectRunning(). Unlike other similar PRs, this is a complete re-write to take advantage of modern toolings in {dplyr}.

  • Use dplyr::consecutive_id() for simplicity & flexibility. This is a huge chang

  • Adds three new args:

    • type & ... (I see this as being mostly useful for type = "site" or similar)
    • name (change column name that gets appended)
    • mode (allows function to filter rather than append a new flag column)
  • Documentation refinements.

  • Add tests.

@jack-davison jack-davison added enhancement Ideas for new features for openair refactor Non user-facing changes utilities 🛠 Openair data utilities, e.g., timeAverage labels Feb 8, 2025
@jack-davison jack-davison mentioned this pull request Feb 8, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for new features for openair refactor Non user-facing changes utilities 🛠 Openair data utilities, e.g., timeAverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant