rollingMean() refinements
#413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- roxygen2md - docs refinements - add type arg (still checks for 'site' for back-compatibility) - input validation
jack-davison
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks
rollingMean(). This one is mainly implemented in C, so there's not much to change.The strangest part of
rollingMean()is that, unlike a lot of functions, it specifically watches for a column called"site"to split the data up. If a user has a column named"site_name"or"station"I guess they were out of luck! To this end, I addedtype(though to not break anyone's existing scripts the function does still look for"site"iftype = "default".Other standard stuff has been done: