Update Bonjour features #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiomoc
commented
Jan 24, 2022
| @@ -20,27 +20,27 @@ | |||
| | 15|MetadataFeature1|bit 1 of MetadataFeatures. Artwork.| | |||
| | 16|MetadataFeature2|bit 2 of MetadataFeatures. Progress. | | |||
| | 17|MetadataFeature0|bit 0 of MetadataFeatures. Text. | | |||
| | 18|AudioFormat1|support for audio format 1| | |||
| | 18|AudioFormat1|support for audio format 1 (PCM)| | |||
| | 19|AudioFormat2|support for audio format 2. This bit must be set for AirPlay 2 connection to work| | |||
wiomoc
commented
Jan 24, 2022
| | 19|AudioFormat2|support for audio format 2. This bit must be set for AirPlay 2 connection to work| | ||
| | 20|AudioFormat3|support for audio format 3. This bit must be set for AirPlay 2 connection to work| | ||
| | 20|AudioFormat3|support for audio format 3 (AAC-LC). This bit must be set for AirPlay 2 connection to work| | ||
| | 21|AudioFormat4|support for audio format 4| |
|
@griff, @systemcrash: What do you think? |
|
Hi @wiomoc - thanks for your attention on this. I realize the documentation here is a bit behind the times, but it's still solid. If you care to update your PR to reflect the content here, which has been verified as correct, then we can accept this. I suspect 21 is ELD, although if so I have not seen it on the audio receiver yet, which makes me think it is sent with video, which the audio receiver doesn't do. This repo, as its name suggests, regards airplay. Carplay, while having a very similar code-base, is a slightly different beast. At least flags 18 and 20 agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in https://github.com/maaiika/Carplay/blob/master/Sources/AirPlayCommon.h