Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dApp Providers (Bitcoin Provider) #162

Merged
merged 60 commits into from
Jun 28, 2024
Merged

Conversation

Thiendekaco
Copy link
Collaborator

No description provided.

@Thiendekaco Thiendekaco force-pushed the openbit-provider-dev branch from b16ee72 to 7dafdca Compare June 13, 2024 05:27
@Thiendekaco Thiendekaco force-pushed the openbit-provider-dev branch from 7dafdca to 23a85ad Compare June 13, 2024 05:37
lw added 3 commits June 13, 2024 15:10
…it-provider

# Conflicts:
#	packages/extension-koni-ui/src/Popup/Confirmations/index.tsx
#	packages/extension-koni-ui/src/Popup/Confirmations/variants/BitcoinSignatureConfirmation.tsx
@Thiendekaco Thiendekaco force-pushed the openbit-provider-dev branch from e68f6a7 to cac1d05 Compare June 13, 2024 11:58
@Thiendekaco Thiendekaco force-pushed the openbit-provider-dev branch from cac1d05 to f507590 Compare June 13, 2024 12:11
@Thiendekaco Thiendekaco force-pushed the openbit-provider-dev branch from 14cd959 to 2859659 Compare June 26, 2024 07:54
@Thiendekaco Thiendekaco force-pushed the openbit-provider-dev branch from 2086084 to 48a6d6f Compare June 27, 2024 05:22

const recipientAccountType = getKeypairTypeByAddress(transactionParams.recipients[0].address);

if (senderAccountType !== recipientAccountType) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can recipient's type different with sender's type?

@saltict
Copy link

saltict commented Jun 27, 2024

🚀 Deployed on https://pr-162--papaya-melba-f5c160.netlify.app

@saltict saltict temporarily deployed to pull request June 27, 2024 11:01 Inactive
@saltict saltict temporarily deployed to pull request June 27, 2024 13:15 Inactive
@saltict saltict temporarily deployed to pull request June 28, 2024 05:49 Inactive
@haiyenvu23 haiyenvu23 linked an issue Jun 28, 2024 that may be closed by this pull request
6 tasks
@saltict saltict merged commit b973d60 into openbit-dev Jun 28, 2024
4 checks passed
@Thiendekaco Thiendekaco changed the title Add method signMessage for bitcoin provider Support dApp Providers (Bitcoin Provider) Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dApp Providers (Bitcoin Provider)
4 participants