forked from Koniverse/SubWallet-Extension
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dApp Providers (Bitcoin Provider) #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thiendekaco
force-pushed
the
openbit-provider-dev
branch
from
June 13, 2024 05:27
b16ee72
to
7dafdca
Compare
Thiendekaco
force-pushed
the
openbit-provider-dev
branch
from
June 13, 2024 05:37
7dafdca
to
23a85ad
Compare
…it-provider # Conflicts: # packages/extension-koni-ui/src/Popup/Confirmations/index.tsx # packages/extension-koni-ui/src/Popup/Confirmations/variants/BitcoinSignatureConfirmation.tsx
Thiendekaco
force-pushed
the
openbit-provider-dev
branch
from
June 13, 2024 11:58
e68f6a7
to
cac1d05
Compare
Thiendekaco
force-pushed
the
openbit-provider-dev
branch
from
June 13, 2024 12:11
cac1d05
to
f507590
Compare
…nto openbit-provider-dev
…nto openbit-provider-dev
…er-dev # Conflicts: # yarn.lock
Thiendekaco
force-pushed
the
openbit-provider-dev
branch
from
June 26, 2024 07:54
14cd959
to
2859659
Compare
…nto openbit-provider-dev
…nto openbit-provider-dev
Thiendekaco
force-pushed
the
openbit-provider-dev
branch
from
June 27, 2024 05:22
2086084
to
48a6d6f
Compare
S2kael
reviewed
Jun 27, 2024
|
||
const recipientAccountType = getKeypairTypeByAddress(transactionParams.recipients[0].address); | ||
|
||
if (senderAccountType !== recipientAccountType) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can recipient's type different with sender's type?
🚀 Deployed on https://pr-162--papaya-melba-f5c160.netlify.app |
6 tasks
Thiendekaco
changed the title
Add method signMessage for bitcoin provider
Support dApp Providers (Bitcoin Provider)
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.