Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SASS #1042

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Migrate SASS #1042

wants to merge 2 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 6, 2025

Fixes #1040.

Vite informs us that our SASS will be deprecated with the next major SASS version (2.0.0). This would stop us from upgrading to the next major vite version (7.0.0), so this patch aims at getting our SASS undeprecated.

Almost all of the changes in this PR were generated with the npm module "sass-migrator".

How to test this

This patch can be tested as usual and only includes style changes. Ideally this patch does not affect how the ui behaves, so the goal of testing this PR is simply to check if everything still works as expected.

Vite informs us that our SASS will be deprecated
with the next major SASS version (2.0.0). This
would stop us from upgrading to the next major
vite version (7.0.0), so this patch aims at getting
our SASS undeprecated.

Almost all of the changes in this PR were generated
with the npm module "sass-migrator".
@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1042

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1042

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request is deployed at test.admin-interface.opencast.org/1042/2025-01-06_11-03-01/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart SASS deprecation warnings
1 participant