Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string "true" not showing in extended metadata #1044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 6, 2025

In the extended metadata tab of the event details, fields with the stirng value "true" or "false" would not render. The fields value could only by checked by clicking into it.

This fixes that by removing a method that, as far as I can tell, is absolutely pointless.

How to test this

To properly test this, an Opencast with extended metadata for either events or series is required. You can find more details on how to configure that here: https://docs.opencast.org/develop/admin/#configuration/metadata/#extended-metadata

In the extended metadata tab of the event details,
fields with the stirng  value "true" or "false" would not
render. The fields value could only by checked by
clicking into it.

This fixes that by removing a method that, as far
as I can tell, is absolutely pointless.
@Arnei Arnei added the type:bug Something isn't working label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1044

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1044

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request is deployed at test.admin-interface.opencast.org/1044/2025-01-06_16-09-47/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant