Clear modal notifs when opening modal #1051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notifications were not being rendered in the metadata tab of the event details, especially the "Active Workflow"-notification. This patch fixes that. This patch also fixes: - The "Active Workflow"-notification being rendered multiple times. - The "Active Workflow"-notification being rendered even when there is no active workflow anymore.
When opening a modal, modal notifications were not properly cleared. This would lead to notifications being displayed in the wrong modals, i.e. "This event cannot be edited due to an active workflow" would appear on a create series modal. This patch should fix that.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1051/2025-01-10_09-07-25/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a modal, modal notifications were not properly cleared. This would lead to notifications being displayed in the wrong modals, i.e. "This event cannot be edited due to an active workflow" would appear on a create series modal. This patch should fix that.
Includes #1021.
How to test this
Can be tested as usual. Trigger a warning in one modal and check if it appears in different modals.