-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update things to work with newer versions of Django #155
Open
evz
wants to merge
10
commits into
opencivicdata:master
Choose a base branch
from
evz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi eric! the james mckinney just fixed the jsonfield thing (like this week). can you rebase off of that? |
Ha! I just did. |
Sorry about the noise here. This is one of those things I thought was gonna be simple. |
no problem. looks like you have some linting issues left? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings! I'm trying to work on a few election related things up in my new home county just north of Milwaukee. I was hoping to incorporate some of the opencivicdata models into the project and hit a bit of a roadblock since it seems that it's been a while since anyone has updated the Django version here. I'm not entirely sure where this project left off in terms of Django versions but it would seem that anything newer than perhaps Django 3.0 won't work because of some of the ways in which they've modified how models and index creation work. Specifically:
index_together
is deprecated in favor ofindexes
Rather than passing a list of fields you'd like to create and index for, you pass a list ofmodels.Index
objects that include the fields you'd like to index.I updated the models and migrations to reflect these changes and tested it out against the latest Django release. I'm not sure how necessary it might be to support versions between 3.0 and 4.2. If that's something that we'll want to do here, I can break these changes out into two different PRs so that it's simpler to cut two different versions.
Anyways, I really hope someone is out there listening still! I notice that @fgregg has been in here in the past year or so which gives me hope!