Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update things to work with newer versions of Django #155

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

evz
Copy link

@evz evz commented Nov 14, 2024

Greetings! I'm trying to work on a few election related things up in my new home county just north of Milwaukee. I was hoping to incorporate some of the opencivicdata models into the project and hit a bit of a roadblock since it seems that it's been a while since anyone has updated the Django version here. I'm not entirely sure where this project left off in terms of Django versions but it would seem that anything newer than perhaps Django 3.0 won't work because of some of the ways in which they've modified how models and index creation work. Specifically:

I updated the models and migrations to reflect these changes and tested it out against the latest Django release. I'm not sure how necessary it might be to support versions between 3.0 and 4.2. If that's something that we'll want to do here, I can break these changes out into two different PRs so that it's simpler to cut two different versions.

Anyways, I really hope someone is out there listening still! I notice that @fgregg has been in here in the past year or so which gives me hope!

@fgregg
Copy link
Contributor

fgregg commented Nov 14, 2024

hi eric! the james mckinney just fixed the jsonfield thing (like this week). can you rebase off of that?

@evz
Copy link
Author

evz commented Nov 14, 2024

Ha! I just did.

@evz
Copy link
Author

evz commented Nov 14, 2024

Sorry about the noise here. This is one of those things I thought was gonna be simple.

@fgregg
Copy link
Contributor

fgregg commented Nov 14, 2024

no problem. looks like you have some linting issues left?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants