Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/cp native files #300

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Issue/cp native files #300

merged 7 commits into from
Sep 27, 2024

Conversation

peterdudfield
Copy link
Collaborator

@peterdudfield peterdudfield commented Sep 27, 2024 •
edited
Loading

Pull Request

Description

store raw files in s3

I put in this issue, as the if statement seems like it could be avoided

How Has This Been Tested?

CI test + ran it locally

note data tailor integration tests are failing right now.

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review September 27, 2024 12:51
@peterdudfield peterdudfield merged commit 89a7e00 into main Sep 27, 2024
2 of 4 checks passed
@peterdudfield peterdudfield deleted the issue/cp-native-files branch September 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc