Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gsp.py #384

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Update gsp.py #384

merged 2 commits into from
Jan 27, 2025

Conversation

pvprajwal
Copy link
Contributor

Pull Request

Description

Updated gsp.py to handle gsp_ids==''

Fixes #383

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings

@sentry-io Sentry.io
Copy link

sentry-io bot commented Jan 17, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/gsp.py

Function Unhandled Issue
get_all_available_forecasts ValueError: invalid literal for int() with base 10: '' /v0/solar/GB/gsp/forecas...
Event Count: 17

Did you find this useful? React with a 👍 or 👎

@peterdudfield peterdudfield merged commit 5e0be41 into openclimatefix:main Jan 27, 2025
1 check passed
@peterdudfield
Copy link
Collaborator

@all-contributors please add @pvprajwal for code

@allcontributors allcontributors bot mentioned this pull request Jan 27, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@peterdudfield

I've put up a pull request to add @pvprajwal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError: invalid literal for int() with base 10: ''
2 participants
@pvprajwal @peterdudfield