-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.2] dmz: overlay: minor fixups #4530
[1.2] dmz: overlay: minor fixups #4530
Conversation
If we want to include the docs changes, can you also include #4525? |
Yes, will be in after it is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
If /run/runc and /usr/bin are on different filesystems, overlayfs may enable the xino feature which results in the following log message: kernel: overlayfs: "xino" feature enabled using 3 upper inode bits. Each time we have to protect /proc/self/exe. So disable xino to remove the log message (we don't care about the inode numbers of the files anyway). Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit 9bc42d6) Signed-off-by: lfbzhm <[email protected]>
Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit aa505bf) Signed-off-by: lfbzhm <[email protected]>
Fixes: 871057d ("drop runc-dmz solution according to overlay solution") Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit b9dfb22) Signed-off-by: lfbzhm <[email protected]>
Arguably these docs should live elsewhere (especially if we plan to remove memfd-bind in the future), but for now this is the only place that fully explains this issue. Suggested-by: Rodrigo Campos <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit ac43589) Signed-off-by: lfbzhm <[email protected]>
42d8781
to
eb676de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport: #4509 and #4525
In addition to some documentation fixes, fix the
xino
dmesg log issue.If /run/runc and /usr/bin are on different filesystems, overlayfs may
enable the xino feature which results in the following log message:
kernel: overlayfs: "xino" feature enabled using 3 upper inode bits.
Each time we have to protect /proc/self/exe. So disable xino to remove
the log message (we don't care about the inode numbers of the files
anyway).
Fixes #4508
Closes #4506
Signed-off-by: Aleksa Sarai [email protected]
Arguably these docs should live elsewhere (especially if we plan to
remove memfd-bind in the future), but for now this is the only place
that fully explains this issue.
Suggested-by: Rodrigo Campos [email protected]
Signed-off-by: Aleksa Sarai [email protected]