The state.json should be generated prior to the creation of the cgroup. #4535
Conversation
|
@kolyshkin Could you help to check this? |
| @@ -561,6 +561,13 @@ func (p *initProcess) start() (retErr error) { | |||
| } | |||
| }() | |||
|
|
|||
| // A SIGKILL can happen at any time, and without the state.json, | |||
| // the 'runc delete --force' command won't be able to clear the cgroup. | |||
| _, err = p.container.updateState(p) | |||
There was a problem hiding this comment.
Thanks.
We should know that we will write the pid of init process to state.json, so when we do delete -f, once this init process has dead, but runc stage 2 process is alive, I think maybe we still can't remove this cgroup path either because there is still one process in this cgroup.
|
I paste the CI error msgs here, you can refer it if you can't see the logs.
To add your Signed-off-by line to every commit in this branch: Ensure you have a local copy of your branch by checking out the pull request locally via command line. |
Fix 4534
Make sure that the state.json is in place before setting up the cgroup or writing 'THAWED' into the freezer.state. This way, the 'runc delete --force' command will work as expected.