Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stac item management functionalities #6

Merged
merged 40 commits into from
Feb 17, 2025
Merged

Implement stac item management functionalities #6

merged 40 commits into from
Feb 17, 2025

Conversation

TiagoOpenCosmos
Copy link
Contributor

This MR adds three new functionalities to the STAC Item:

  • create item
  • update item
  • delete item

@TiagoOpenCosmos TiagoOpenCosmos force-pushed the implement-query-functionalities-stac-catalog branch from e9158ce to 49d5780 Compare February 6, 2025 11:33
@TiagoOpenCosmos TiagoOpenCosmos force-pushed the implement-stac-item-management branch from d52c462 to 73b445c Compare February 6, 2025 11:36
Base automatically changed from implement-query-functionalities-stac-catalog to develop February 6, 2025 17:50
pepjo
pepjo reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@pepjo pepjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far :)

@TiagoOpenCosmos
Fix issues in create_item, update_item and delete_item methods; Adapt…
038dff9 
… unit tests to changes in stac item methods; create unit test for ItemUpdate model
@TiagoOpenCosmos TiagoOpenCosmos force-pushed the implement-stac-item-management branch from 73b445c to 038dff9 Compare February 8, 2025 16:30
pepjo
pepjo reviewed Feb 10, 2025
View reviewed changes
pepjo
pepjo requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@pepjo pepjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Readme looks very good, I just think that we need to change the perspective towards a library users first, library developer second.

@TiagoOpenCosmos TiagoOpenCosmos merged commit 73fa55e into develop Feb 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepjo pepjo pepjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiagoOpenCosmos @pepjo