chore(elastic-upgrade): clean up returns and any type

opencrvs · Jul 17, 2024 · 7dd9e81 · 7dd9e81
1 parent 01ea505
commit 7dd9e81
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/packages/migration/src/utils/elasticsearch-helper.ts b/packages/migration/src/utils/elasticsearch-helper.ts
@@ -42,9 +42,8 @@ export const updateComposition = async (
     )
   } catch (e) {
     console.error(`updateComposition: error: ${e}`)
+    return
   }
-
-  return
 }
 
 export const renameField = async (

diff --git a/packages/search/src/features/search/handler.ts b/packages/search/src/features/search/handler.ts
@@ -140,7 +140,7 @@ export async function getStatusWiseRegistrationCountHandler(
     }
 
     const response = await client.search<
-      any,
+      SearchDocument,
       {
         statusCounts: {
           buckets: Array<{

diff --git a/packages/search/src/features/search/service.ts b/packages/search/src/features/search/service.ts
@@ -59,9 +59,9 @@ export const advancedSearch = async (
   payload: ISearchCriteria
 ) => {
   const formattedParams = await formatSearchParams(payload, isExternalSearch)
-  let response
+
   try {
-    response = await client.search(formattedParams, {
+    return await client.search(formattedParams, {
       ignore: !isExternalSearch ? [404] : undefined,
       meta: true
     })
@@ -71,8 +71,6 @@ export const advancedSearch = async (
     } else {
       logger.error('Search error: ', error)
     }
-    return undefined
+    return
   }
-
-  return response
 }