Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I want to select a template to issue a certified copy with #7813

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Oct 22, 2024

@tareq89 tareq89 added this to the v1.7.0 milestone Oct 22, 2024
@tareq89 tareq89 self-assigned this Oct 22, 2024

This comment has been minimized.

@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7584.opencrvs.dev

@rikukissa
Copy link
Member

rikukissa commented Oct 31, 2024

Seems the dropdown and the radio buttons in a different order to how the design is:

image

Design
image

collector?: Partial<{ type: Relation | string }>
collector?: Partial<{
type: Relation | string
certificateTemplateId?: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for certificateTemplateId also existing inside the collector object?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as shown in the screenshot, in the collector form, there is no longer only one field (type), but rather two fields (type and certificateTemplateId).
In the collector form, this form's value resides inside sectionData which is an ICertificate type. To access the type (collector type) value as well as certificateTemplateId (selected certificate template), I needed to add this optional property here.

packages/client/src/declarations/selectors.ts Outdated Show resolved Hide resolved
packages/workflow/src/documents.ts Show resolved Hide resolved
packages/commons/src/fhir/extension.ts Show resolved Hide resolved
Co-authored-by: Riku Rouvila <[email protected]>
@tareq89
Copy link
Collaborator Author

tareq89 commented Oct 31, 2024

Seems the dropdown and the radio buttons in a different order to how the design is:

image

Design image

I did not know such design existed. Any figma link of this design was not mentioned anywhere. Anyway, I have adjusted the code as per the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants