-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user I want to select a template to issue a certified copy with #7813
base: develop
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
…to ReviewCertificate before print in advance
…r certified copies changes
Your environment is deployed to https://ocrvs-7584.opencrvs.dev |
...lient/src/forms/register/mappings/event-specific-fields/birth/query/registration-mappings.ts
Outdated
Show resolved
Hide resolved
Seems the dropdown and the radio buttons in a different order to how the design is: |
collector?: Partial<{ type: Relation | string }> | ||
collector?: Partial<{ | ||
type: Relation | string | ||
certificateTemplateId?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for certificateTemplateId
also existing inside the collector object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as shown in the screenshot, in the collector form, there is no longer only one field (type), but rather two fields (type and certificateTemplateId).
In the collector form, this form's value resides inside sectionData which is an ICertificate
type. To access the type
(collector type) value as well as certificateTemplateId
(selected certificate template), I needed to add this optional property here.
packages/client/src/views/PrintCertificate/collectorForm/CollectorForm.tsx
Outdated
Show resolved
Hide resolved
.../migration/src/migrations/hearth/20241029171702-add-certificateTemplateId-to-missing-docs.ts
Outdated
Show resolved
Hide resolved
.../migration/src/migrations/hearth/20241029171702-add-certificateTemplateId-to-missing-docs.ts
Show resolved
Hide resolved
Co-authored-by: Riku Rouvila <[email protected]>
I did not know such design existed. Any figma link of this design was not mentioned anywhere. Anyway, I have adjusted the code as per the design. |
#7584