Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up E-Signet / OIDP verification button code #7862

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Oct 29, 2024

Cleaning up any hard-coded code regarding to OIDP/E-Signet functionality. This code can be referred to when re-implemented into @opencrvs/mosip repository, but we want to separate it from core for enhancing opencrvs-core modularity.

The code will be brought back non-hardcoded into core in #6954

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://clean-up-esignet.opencrvs.dev

@naftis naftis changed the title chore: clean up OIDP verification button code chore: clean up E-Signet / OIDP verification button code Oct 29, 2024
@naftis naftis force-pushed the clean-up-esignet branch 2 times, most recently from a7a27a6 to 9e9912d Compare October 29, 2024 11:54
@naftis naftis merged commit 74c5f3f into develop Oct 29, 2024
58 checks passed
@naftis naftis deleted the clean-up-esignet branch October 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants