Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint backward compatibility #154

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

fbunt
Copy link
Contributor

@fbunt fbunt commented May 16, 2024

Fixes #153

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (6af5d0c) to head (663af37).
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
+ Coverage    95.26%   95.32%   +0.05%     
===========================================
  Files           31       31              
  Lines         5323     5451     +128     
===========================================
+ Hits          5071     5196     +125     
- Misses         252      255       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kirill888
Copy link
Member

@fbunt thanks, but can you please fix this via import from future instead, like here for example:

from __future__ import annotations

@SpacemanPaul
Copy link
Contributor

I see setup.cfg still advertises support for Python >=3.8.

This should probably be bumped to at least 3.9 as 3.8 is now end-of-lifed and unmaintained.

@fbunt
Copy link
Contributor Author

fbunt commented May 17, 2024

@Kirill888 Oh I didn't know about that one, thanks! Done.

@fbunt fbunt changed the title Use Union instead of bar for multiple types hint Fix type hint backward compatibility May 17, 2024
@Kirill888 Kirill888 merged commit a49d558 into opendatacube:develop May 18, 2024
11 checks passed
@fbunt fbunt deleted the issue-153 branch May 20, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of newer type hinting syntax breaks for Python < 3.10
3 participants