Implement Prometheus metrics for LocalQueue (#3673) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1890352274a2cdb60b7e19b86386352ed0145983
Co-authored-by: Mykhailo Bobrovskyi <[email protected]>
Co-authored-by: Mykhailo Bobrovskyi <[email protected]>
…etes-sigs#2692) Signed-off-by: Yuki Iwai <[email protected]> Co-authored-by: Yuki Iwai <[email protected]>
Co-authored-by: Traian Schiau <[email protected]>
…#2707) * Add update-security-insights directive * Use GIT_TAG instead of RELEASE_VERSION --------- Co-authored-by: Irving Mondragón <[email protected]>
Co-authored-by: Mykhailo Bobrovskyi <[email protected]>
…tes-sigs#2740) Co-authored-by: Mykhailo Bobrovskyi <[email protected]>
Signed-off-by: Yuki Iwai <[email protected]> Co-authored-by: Yuki Iwai <[email protected]>
* Cleanup to use FlavorResourceQuantities.Add in cache (kubernetes-sigs#2696) * fix: Refactor FitInCohort tests (kubernetes-sigs#2655) * fix: Refactor FitInCohorot tests * fix: delete no-op function * fix: use new method to add usage * fix: to enforce resource group constraint for flavors and resources * fix: consolidated into a single resource group * fix: delete flavorNames * fix: adjusted test cases to align with existing expected conditions * fix: change FlavorResourceQuantitiesFlat value * Finish flattening of FlavorResourceQuantities (kubernetes-sigs#2721) * Finish Flattenning FlavorResourceQuantities * Rename FlavorResourceQuantitiesFlat to FlavorResourceQuantities * Cleanup preemption.go (kubernetes-sigs#2800) * [Partial Admission] Check Mode before attempting Preemption (kubernetes-sigs#2809) * Prefer Reclamation to Priority Based Preemption (kubernetes-sigs#2811) --------- Co-authored-by: s-shiraki <[email protected]>
* Move declaration of the Preempted reasons to API pkg * Fix when PrioritySortingWithingCohort is disabled
…staging registry (kubernetes-sigs#2832) * Publish images to new staging registry * Update image registry name --------- Co-authored-by: Irving Mondragón <[email protected]>
Co-authored-by: Irving Mondragón <[email protected]>
…ter deleting resource from (kubernetes-sigs#2879) * Fixed overadmission after deleting resource from borrowing CQ. * Removed filterLocalQueueUsage. * Removed empty FlavorResourceQuantities objects on tests.
…hot clusterQueue. (kubernetes-sigs#2918) * Deep clone ResourceGroups instead shallow copy on snapshot clusterQueue. * Initialize ResourceGroups to the size of the original. --------- Co-authored-by: Mykhailo Bobrovskyi <[email protected]>
Change-Id: I482b40fa841bcfa5b409425f3015b27723940b85
…ebhook on new CRDs availability (kubernetes-sigs#2991) * Start Controller and Webhook on new CRDs availability * Log errors from JobFramework controller and webhook * Add test case for delayed JobFramework API becoming available * Wait for API integration to be enabled * Implement synchronization for safe concurrent access * Implement exponential backoff for waitForAPI() and add function type to streamline REST mapping checks * Add Job Framework API to mapper directly * Cast mgr.GetRESTMapper() to *TestRESTMapper and ensure proper locking for tests
The following users havent contributed in the recent past. Moving to emeritus approvers. - anishasthana - jbusche - maxusmusti - tedhtchang Signed-off-by: Anish Asthana <[email protected]>
…ocalQueue status. Commit to be dropped later. Taken from PR: kubernetes-sigs#3143
…g and mutating webhooks to interfere with system jobs
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KPostOffice
force-pushed
the
lq-metrics
branch
from
99ee06a to
63fa660
Compare
* add LocalQueue metrics (no feature gate) Signed-off-by: Kevin <[email protected]> * add all clear and report calls Signed-off-by: Kevin <[email protected]> * add feature gate Signed-off-by: Kevin <[email protected]> * cleanup todos and add more feature gates Signed-off-by: Kevin <[email protected]> * use feature gate instead of config Signed-off-by: Kevin <[email protected]> * cleanup Signed-off-by: Kevin <[email protected]> * add metrics checks to a test Signed-off-by: Kevin <[email protected]> * add lq metrics to cq integration test Signed-off-by: Kevin <[email protected]> * lint fix Signed-off-by: Kevin <[email protected]> * use name instead of local_queue Signed-off-by: Kevin <[email protected]> * update status metric description Signed-off-by: Kevin <[email protected]> * fix key name Signed-off-by: Kevin <[email protected]> * move registerLQ into metrics package Signed-off-by: Kevin <[email protected]> --------- Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
lq-metrics
branch
from
63fa660 to
d46377c
Compare
|
/retest |
KPostOffice
force-pushed
the
lq-metrics
branch
from
d46377c to
a6c69c6
Compare
Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
lq-metrics
branch
from
a6c69c6 to
b859cc2
Compare
|
/retest |
|
I was debugging this test and noticed that the image being used when I ran the test was |
ChristianZaccaria
force-pushed
the
dev
branch
3 times, most recently
from
367ed20 to
ce05603
Compare
|
@KPostOffice: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ChristianZaccaria
force-pushed
the
dev
branch
from
ce05603 to
22d4e3d
Compare
ChristianZaccaria
force-pushed
the
dev
branch
from
c41e3de to
5471c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick of local-queue metrics features