Upgrade to Node 22

opendatahub-io · Feb 20, 2025 · 2ea305f · 2ea305f
1 parent f96c030
commit 2ea305f
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 15 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -5,7 +5,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [22.x]
     steps:
       - uses: actions/checkout@v4
       - name: Setup Node.js ${{ matrix.node-version }}
@@ -41,7 +41,7 @@ jobs:
             ${{ github.workspace }}/node_modules
             ${{ github.workspace }}/backend/node_modules
             ${{ github.workspace }}/frontend/node_modules
-          key: ${{ runner.os }}-18.x-modules-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-22.x-modules-${{ hashFiles('**/package-lock.json') }}
       - name: Run linting and formatting checks
         run: npm run lint:frontend:backend
 
@@ -58,7 +58,7 @@ jobs:
             ${{ github.workspace }}/node_modules
             ${{ github.workspace }}/backend/node_modules
             ${{ github.workspace }}/frontend/node_modules
-          key: ${{ runner.os }}-18.x-modules-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-22.x-modules-${{ hashFiles('**/package-lock.json') }}
       - name: Run backend unit tests with coverage
         run: |
           npm run test:backend:unit-coverage
@@ -147,7 +147,7 @@ jobs:
             ${{ github.workspace }}/node_modules
             ${{ github.workspace }}/backend/node_modules
             ${{ github.workspace }}/frontend/node_modules
-          key: ${{ runner.os }}-18.x-modules-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-22.x-modules-${{ hashFiles('**/package-lock.json') }}
       - name: Run Cypress Mock tests
         run: |
           if [ "${{ matrix.test-group }}" == "default" ]; then
@@ -225,7 +225,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [22.x]
     needs:
       - Setup
       - Lint

diff --git a/Dockerfile b/Dockerfile
@@ -2,7 +2,7 @@
 ARG SOURCE_CODE=.
 
 # Use ubi8/nodejs-18 as default base image
-ARG BASE_IMAGE="registry.access.redhat.com/ubi8/nodejs-18:latest"
+ARG BASE_IMAGE="registry.access.redhat.com/ubi9/nodejs-22:latest"
 
 FROM ${BASE_IMAGE} as builder
 

diff --git a/backend/package-lock.json b/backend/package-lock.json
diff --git a/backend/package.json b/backend/package.json
@@ -14,7 +14,7 @@
     "url": "https://github.com/opendatahub-io/odh-dashboard/issues"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=22.0.0"
   },
   "main": "src/server.ts",
   "scripts": {

diff --git a/docs/dev-setup.md b/docs/dev-setup.md
@@ -5,8 +5,8 @@
 ODH requires the following to run:
 
 - [NodeJS and NPM](https://nodejs.org/)
-  - Node recommended version -> `18.18.2`
-  - NPM recommended version -> `9.8.1`
+  - Node recommended version -> `22.5.1`
+  - NPM recommended version -> `10.8.2`
 - [OpenShift CLI](https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/cli_tools/openshift-cli-oc)
 - [kustomize](https://github.com/kubernetes-sigs/kustomize) (if you need to do deployment)
 

diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -14,7 +14,7 @@
     "url": "https://github.com/opendatahub-io/odh-dashboard/issues"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=22.0.0"
   },
   "scripts": {
     "build": "run-s build:prod",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -14,7 +14,7 @@
     "url": "https://github.com/opendatahub-io/odh-dashboard/issues"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=22.0.0"
   },
   "scripts": {
     "build": "run-p -l build:*",

diff --git a/scripts/ci/Dockerfile b/scripts/ci/Dockerfile
@@ -7,7 +7,7 @@ ARG CYPRESS_CACHE=$USER_HOME/.cypress-cache
 ARG CHROME=https://dl.google.com/linux/direct/google-chrome-stable_current_x86_64.rpm
 ARG OCP_CLI=https://mirror.openshift.com/pub/openshift-v4/clients/ocp/stable/openshift-client-linux.tar.gz
 ARG NVM_INSTALLER=https://raw.githubusercontent.com/creationix/nvm/v0.39.7/install.sh
-ARG NODE_VERSION=v20.15.0
+ARG NODE_VERSION=v22.5.1
 
 USER root