-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ilab project selector modal #3809
Add ilab project selector modal #3809
Conversation
392ecc5
to
bbd11f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3809 +/- ##
==========================================
- Coverage 84.62% 84.62% -0.01%
==========================================
Files 1523 1526 +3
Lines 35324 35379 +55
Branches 9885 9902 +17
==========================================
+ Hits 29894 29940 +46
- Misses 5430 5439 +9
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
SO that error comes up because the pipeline server is not ready and you are trying to make calls within it. Usually we wrap components that use these pipeline calls in I think you need to only call the useIlab hook if it is ready, so you could export const useIlabPipeline = (): FetchState<PipelineVersionKF | null> => {
const { pipelinesServer } = usePipelinesAPI();
const [ilabPipeline, ilabPipelineLoaded, ilabPipelineLoadError, refreshIlabPipeline] =
usePipelineByName(
pipelinesServer.compatible && pipelinesServer.installed ? ILAB_PIPELINE_NAME : '',
); this will stop the ilab from calling if the pipeline server is not ready |
b68afcd
to
fc022ce
Compare
fc022ce
to
e4d8845
Compare
e4d8845
to
bd6abac
Compare
@Gkrumbach07 thank you for the tip! It does help reduce the number of unnecessary requests, but the issue persists. Anyway, I'm leaving this PR ready to go in case we want to merge it and address that issue in a different ticket. EDIT: When the error happens, |
ok i logged a follow up so we can unblock https://issues.redhat.com/browse/RHOAIENG-20647 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
064f388
into
opendatahub-io:main
Description
See https://issues.redhat.com/browse/RHOAIENG-20120
Note: I'm seeing
Error communicating with pipeline server
as the value ofilabPipelineLoadError
while the ilab pipeline is being loaded. This makes one of the warning alerts to be shown temporarily. See the video below when I select theilab
project:RHOAIENG-20120.mov
How Has This Been Tested?
Add the
StartRunModal
component somewhere in the code and select the projects.Test Impact
Test coverage is included for the relevant code.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main