Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage ilab pipeline at project scope #3824

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Feb 27, 2025

JIRA: RHOAIENG-20463

Description

  1. When configuring the pipeline server, add a section to allow enabling InstructLab pipeline in the project, which will add a field in the DSPA and trigger an auto-import of the ilab pipeline.
Screenshot 2025-02-27 at 3 57 04 PM
  1. If the server is already configured, we have this dropdown item in the split button action named Manage sample pipelines, and you will have a modal to enable it or not. Toggle the checkbox will show different alerts.
Screenshot 2025-02-27 at 4 11 49 PM Screenshot 2025-02-27 at 4 13 05 PM Screenshot 2025-02-28 at 11 35 51 AM Screenshot 2025-02-28 at 11 37 40 AM
  1. When it's toggled, it will show a notification to notify the user whether it's enabled or not. When it's enabled, there is a notification watcher to keep polling ilab pipeline and the dspa status, so it will know when it's available and send another notification again.
Screenshot 2025-02-28 at 11 39 11 AM Screenshot 2025-02-27 at 4 16 45 PM
  1. Remove the ilab enable from the cluster settings page

Check the recording for more details:

Screen.Recording.2025-02-27.at.4.21.35.PM.mp4

How Has This Been Tested?

  1. Configure a pipeline server with ilab enabled
  2. Wait for a few seconds
  3. Make sure can import the ilab pipeline automatically and send a notification
  4. On the pipelines list toolbar, open the manage sample pipelines modal again
  5. Disable the ilab pipeline
  6. Manually delete the ilab pipeline
  7. Wait for ~10 seconds for DSPA to change
  8. Enable ilab pipeline again
  9. See the notification and wait for the auto import

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 30.08130% with 86 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (f363cfb) to head (bf9c4e3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/pipelines/content/ManageSamplePipelinesModal.tsx 4.83% 59 Missing ⚠️
...notificationWatcher/NotificationWatcherContext.tsx 40.00% 6 Missing ⚠️
...ePipelinesServer/InstructLabPipelineEnablement.tsx 14.28% 6 Missing ⚠️
...ePipelinesServer/SamplePipelineSettingsSection.tsx 14.28% 6 Missing ⚠️
...lines/content/import/ImportPipelineSplitButton.tsx 73.68% 5 Missing ⚠️
frontend/src/api/pipelines/k8s.ts 33.33% 2 Missing ⚠️
...ePipelinesServer/ConfigurePipelinesServerModal.tsx 66.66% 1 Missing ⚠️
...s/pipelines/global/pipelines/GlobalNoPipelines.tsx 80.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (30.08%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3824      +/-   ##
==========================================
- Coverage   84.58%   84.38%   -0.20%     
==========================================
  Files        1524     1525       +1     
  Lines       35383    35465      +82     
  Branches     9901     9927      +26     
==========================================
+ Hits        29927    29928       +1     
- Misses       5456     5537      +81     
Files with missing lines Coverage Δ
frontend/src/api/k8s/dsc.ts 100.00% <ø> (ø)
...ipelines/content/configurePipelinesServer/utils.ts 87.50% <100.00%> (+0.22%) ⬆️
...ines/content/tables/pipeline/PipelinesTableRow.tsx 92.42% <ø> (ø)
...rc/concepts/pipelines/context/PipelinesContext.tsx 93.87% <100.00%> (+0.19%) ⬆️
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
...tend/src/pages/clusterSettings/ClusterSettings.tsx 93.67% <100.00%> (-1.99%) ⬇️
...ePipelinesServer/ConfigurePipelinesServerModal.tsx 75.51% <66.66%> (-0.58%) ⬇️
...s/pipelines/global/pipelines/GlobalNoPipelines.tsx 80.00% <80.00%> (-20.00%) ⬇️
frontend/src/api/pipelines/k8s.ts 92.85% <33.33%> (-7.15%) ⬇️
...lines/content/import/ImportPipelineSplitButton.tsx 87.27% <73.68%> (-7.73%) ⬇️
... and 4 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f363cfb...bf9c4e3. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Feb 28, 2025
@openshift-ci openshift-ci bot removed the lgtm label Feb 28, 2025
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold This PR is hold for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants