Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Env to define POD_NAMESPACE #110

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

vaibhavjainwiz
Copy link
Member

odh-model-controller should aware about the namespace in which controller pod is running. POD_NAMESPACE is the env which read by controller for it. POD_NAMESPACE is used by odh-model-controller while creating the generic route to read inferenceservice-config configmap to read ingress configurations.
https://github.com/opendatahub-io/odh-model-controller/blob/main/controllers/reconcilers/kserve_route_reconciler.go#L77

With this PR I am initializing the POD_NAMESPACE env. It is required for #67

Description

How Has This Been Tested?

It could be tested with #100

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rpancham
Copy link
Contributor

rpancham commented Oct 26, 2023

Verified the changes of this PR along with #111

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit c1f9611 into opendatahub-io:main Oct 26, 2023
5 checks passed
@vaibhavjainwiz vaibhavjainwiz deleted the generic-route branch December 1, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose generic OpenShift routes for KServe InferenceServices
3 participants