-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove old prometheus clusterrole #129
remove old prometheus clusterrole #129
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
return ctrl.Result{}, err | ||
} | ||
log.Info("Monitoring Controller reconciled successfully.") | ||
// log.Info("Monitoring Controller reconciling.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete monitoring_controller.go
file is resposible for doing reconcileRoleBinding
. If these reconcilation is not needed anymore then I would suggest to remove this complete controller and all its references.
Do we still need this PR? |
@VedantMahabaleshwarkar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
closed as stale. |
Description
How Has This Been Tested?
Merge criteria: