Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for modelmeshserving as component #1338

Open
wants to merge 1 commit into
base: feature-operator-refactor
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 4, 2024

Description

add modelmeshserving into component
introduce a non-DSC spec visible modelcontroller component.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw force-pushed the jira/13177 branch 2 times, most recently from 6694329 to d862434 Compare November 4, 2024 10:56
@zdtsw
Copy link
Member Author

zdtsw commented Nov 4, 2024

/test opendatahub-operator-e2e

@@ -21,6 +21,10 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

const (
ModelMeshCtrlerComponentName = "odh-model-controller" // shared by kserve and mm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ModelMeshCtrlerComponentName = "odh-model-controller" // shared by kserve and mm
ModelControllerComponentName = "odh-model-controller" // shared by kserve and mm

I assume that it shouldn't have ModelMesh in the name if it's not modelmesh specific?

@zdtsw zdtsw force-pushed the jira/13177 branch 2 times, most recently from f2ae263 to 206adab Compare November 19, 2024 15:55
@zdtsw zdtsw force-pushed the jira/13177 branch 2 times, most recently from 2fbf65d to f84aa91 Compare November 19, 2024 17:38
@zdtsw zdtsw changed the title [WIP] feat: add support for modelmeshserving as component feat: add support for modelmeshserving as component Nov 19, 2024
- add new modelcontroller component: do not show in DSC.components
- e2e on modelcontroller wont run in parallel but after others are done
- if modelmesh is enabled, or kserve (later) is enabled, modelcontroller should be managed

Signed-off-by: Wen Zhou <[email protected]>
Copy link

openshift-ci bot commented Nov 19, 2024

@zdtsw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e b828d2a link true /test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants