-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for modelmeshserving as component #1338
base: feature-operator-refactor
Are you sure you want to change the base?
feat: add support for modelmeshserving as component #1338
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6694329
to
d862434
Compare
/test opendatahub-operator-e2e |
cb90c62
to
a833dd5
Compare
apis/components/v1/kserve_types.go
Outdated
@@ -21,6 +21,10 @@ import ( | |||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
) | |||
|
|||
const ( | |||
ModelMeshCtrlerComponentName = "odh-model-controller" // shared by kserve and mm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModelMeshCtrlerComponentName = "odh-model-controller" // shared by kserve and mm | |
ModelControllerComponentName = "odh-model-controller" // shared by kserve and mm |
I assume that it shouldn't have ModelMesh in the name if it's not modelmesh specific?
f2ae263
to
206adab
Compare
2fbf65d
to
f84aa91
Compare
- add new modelcontroller component: do not show in DSC.components - e2e on modelcontroller wont run in parallel but after others are done - if modelmesh is enabled, or kserve (later) is enabled, modelcontroller should be managed Signed-off-by: Wen Zhou <[email protected]>
@zdtsw: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
add modelmeshserving into component
introduce a non-DSC spec visible modelcontroller component.
How Has This Been Tested?
Screenshot or short clip
Merge criteria