Skip to content

Commit

Permalink
Merge changes I81b53d0e,I15ff8bc4
Browse files Browse the repository at this point in the history
* changes:
  Bump upstreams
  Use constructor injection in aaa-password-service
  • Loading branch information
rovarga authored and Gerrit Code Review committed Dec 29, 2023
2 parents c7c0068 + b0375bc commit 114ab81
Show file tree
Hide file tree
Showing 22 changed files with 43 additions and 43 deletions.
2 changes: 1 addition & 1 deletion aaa-encrypt-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ and is available at http://www.eclipse.org/legal/epl-v10.html INTERNAL
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent-lite</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
*/
package org.opendaylight.aaa.impl.password.service;

import static java.util.Objects.requireNonNull;

import com.google.common.annotations.Beta;
import com.google.common.collect.Iterables;
import java.util.Collection;
Expand All @@ -30,22 +32,20 @@
import org.slf4j.LoggerFactory;

@Beta
@Component(immediate = true)
@Component(service = { })
public final class OSGiPasswordServiceConfigBootstrap
implements ClusteredDataTreeChangeListener<PasswordServiceConfig> {
private static final Logger LOG = LoggerFactory.getLogger(OSGiPasswordServiceConfigBootstrap.class);

@Reference
DataBroker dataBroker = null;

@Reference(target = "(component.factory=" + OSGiPasswordServiceConfig.FACTORY_NAME + ")")
ComponentFactory<OSGiPasswordServiceConfig> configFactory = null;

private final ComponentFactory<OSGiPasswordServiceConfig> configFactory;
private ListenerRegistration<?> registration;
private ComponentInstance<?> instance;

@Activate
synchronized void activate() {
public OSGiPasswordServiceConfigBootstrap(@Reference final DataBroker dataBroker,
@Reference(target = "(component.factory=" + OSGiPasswordServiceConfig.FACTORY_NAME + ")")
final ComponentFactory<OSGiPasswordServiceConfig> configFactory) {
this.configFactory = requireNonNull(configFactory);
registration = dataBroker.registerDataTreeChangeListener(
DataTreeIdentifier.create(LogicalDatastoreType.CONFIGURATION,
InstanceIdentifier.create(PasswordServiceConfig.class)), this);
Expand Down Expand Up @@ -77,7 +77,7 @@ public synchronized void onDataTreeChanged(final Collection<DataTreeModification
@Holding("this")
private void updateInstance(final PasswordServiceConfig config) {
if (registration != null) {
final ComponentInstance<?> newInstance = configFactory.newInstance(
final var newInstance = configFactory.newInstance(
OSGiPasswordServiceConfig.props(config != null ? config : new PasswordServiceConfigBuilder().build()));
if (instance != null) {
instance.dispose();
Expand Down
2 changes: 1 addition & 1 deletion aaa-password-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ and is available at http://www.eclipse.org/legal/epl-v10.html INTERNAL
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent-lite</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion aaa-shiro/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ and is available at http://www.eclipse.org/legal/epl-v10.html INTERNAL
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent-lite</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion aaa-shiro/repackaged-shiro-jar/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion artifacts/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent-lite</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
14 changes: 7 additions & 7 deletions docs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down Expand Up @@ -116,7 +116,7 @@
<dependency>
<groupId>org.opendaylight.infrautils</groupId>
<artifactId>inject.guice.testutils</artifactId>
<version>6.0.4</version>
<version>6.0.5</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -256,11 +256,11 @@
<link>https://guava.dev/releases/32.0.1-jre/api/docs/</link>
<link>https://commons.apache.org/proper/commons-lang/javadocs/api-release/</link>

<link>https://www.javadoc.io/doc/org.opendaylight.odlparent/odlparent-docs/13.0.7/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.infrautils/infrautils-docs/6.0.4/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.yangtools/yangtools-docs/11.0.4/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.mdsal/mdsal-docs/12.0.3/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.controller/controller-docs/8.0.3/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.odlparent/odlparent-docs/13.0.10/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.infrautils/infrautils-docs/6.0.5/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.yangtools/yangtools-docs/11.0.5/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.mdsal/mdsal-docs/12.0.4/</link>
<link>https://www.javadoc.io/doc/org.opendaylight.controller/controller-docs/8.0.4/</link>
</links>

<!--groups>
Expand Down
2 changes: 1 addition & 1 deletion features/features-aaa/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>feature-repo-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions features/odl-aaa-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down Expand Up @@ -50,7 +50,7 @@
<dependency>
<groupId>org.opendaylight.mdsal</groupId>
<artifactId>odl-mdsal-binding-base</artifactId>
<version>12.0.3</version>
<version>12.0.4</version>
<type>xml</type>
<classifier>features</classifier>
</dependency>
Expand Down
4 changes: 2 additions & 2 deletions features/odl-aaa-cert/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand All @@ -27,7 +27,7 @@
<dependency>
<groupId>org.opendaylight.controller</groupId>
<artifactId>odl-mdsal-broker</artifactId>
<version>8.0.3</version>
<version>8.0.4</version>
<type>xml</type>
<classifier>features</classifier>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion features/odl-aaa-cli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions features/odl-aaa-encryption-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand All @@ -28,7 +28,7 @@
<dependency>
<groupId>org.opendaylight.controller</groupId>
<artifactId>controller-artifacts</artifactId>
<version>8.0.3</version>
<version>8.0.4</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
6 changes: 3 additions & 3 deletions features/odl-aaa-password-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down Expand Up @@ -60,14 +60,14 @@
<dependency>
<groupId>org.opendaylight.mdsal</groupId>
<artifactId>odl-mdsal-binding-base</artifactId>
<version>12.0.3</version>
<version>12.0.4</version>
<type>xml</type>
<classifier>features</classifier>
</dependency>
<dependency>
<groupId>org.opendaylight.controller</groupId>
<artifactId>odl-mdsal-broker</artifactId>
<version>8.0.3</version>
<version>8.0.4</version>
<type>xml</type>
<classifier>features</classifier>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion features/odl-aaa-shiro/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions features/odl-aaa-web/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand All @@ -35,7 +35,7 @@
<dependency>
<groupId>org.opendaylight.yangtools</groupId>
<artifactId>yangtools-artifacts</artifactId>
<version>11.0.4</version>
<version>11.0.5</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion features/odl-apache-shiro/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>single-feature-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion features/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent-lite</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion karaf/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>karaf4-parent</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.opendaylight.mdsal</groupId>
<artifactId>binding-parent</artifactId>
<version>12.0.3</version>
<version>12.0.4</version>
<relativePath/>
</parent>

Expand All @@ -28,7 +28,7 @@
<dependency>
<groupId>org.opendaylight.controller</groupId>
<artifactId>controller-artifacts</artifactId>
<version>8.0.3</version>
<version>8.0.4</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent-lite</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion web/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent-lite</artifactId>
<version>13.0.7</version>
<version>13.0.10</version>
<relativePath/>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion web/testutils/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<dependency>
<groupId>org.opendaylight.infrautils</groupId>
<artifactId>infrautils-artifacts</artifactId>
<version>6.0.4</version>
<version>6.0.5</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down

0 comments on commit 114ab81

Please sign in to comment.