This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add UX support for HC detector #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will fix UT while reviewing |
|
current UT passed. will add more UT for new code. |
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
public/pages/AnomalyCharts/containers/AnomalyOccurrenceChart.tsx
Outdated
Show resolved
Hide resolved
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ylwu-amzn
reviewed
Oct 16, 2020
| }; | ||
|
|
||
| const showLoader = useDelayedLoader(props.isLoading || isLoadingAlerts); | ||
| const showLoader = useDelayedLoader(props.isLoading); |
There was a problem hiding this comment.
Any impact to single entity detector by removing isLoadingAlerts ?
There was a problem hiding this comment.
no. it will be there for AnomalyDetailsChart
ylwu-amzn
reviewed
Oct 16, 2020
| props.showAlerts === undefined || !props.showAlerts | ||
| ? [ | ||
| <EuiSpacer size="m" />, | ||
| <AnomalyOccurrenceChart |
There was a problem hiding this comment.
AnomalyOccurrenceChart is only used by HC detector and AnomalyDetailChart is only used single entity detector?
There was a problem hiding this comment.
Yes, and AnomalyOccurrenceChart contains AnomalyDetailChart. AnomalyOccurrenceChart is actually wrapper of AnomalyDetailChart, making AnomalyDetailChart a separate chart so that it can be easily re-used in multiple places
ylwu-amzn
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
public/pages/DetectorResults/containers/AnomalyResultsTable.tsx
Outdated
Show resolved
Hide resolved
ohltyler
reviewed
Oct 16, 2020
public/pages/DetectorResults/containers/AnomalyResultsTable.tsx
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Oct 16, 2020
ylwu-amzn
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 16, 2020
yizheliu-amazon
commented
Oct 16, 2020
| @@ -0,0 +1,388 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file is refactored from AnomaliesChart.
ohltyler
reviewed
Oct 16, 2020
ohltyler
reviewed
Oct 19, 2020
ohltyler
reviewed
Oct 19, 2020
ohltyler
reviewed
Oct 19, 2020
ohltyler
reviewed
Oct 19, 2020
ylwu-amzn
approved these changes
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add UX support for HC detector.
Preview for HC detector:
DetectorResult for HC detector:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.