Improving rolls with meme replies #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is not necessary and breaks pip install -r requirements.txt. See https://stackoverflow.com/questions/39577984/what-is-pkg-resources-0-0-0-in-output-of-pip-freeze-command
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 0.14.1 to 0.15.3. - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/master/CHANGES.rst) - [Commits](pallets/werkzeug@0.14.1...0.15.3) Signed-off-by: dependabot[bot] <[email protected]>
Update roll.py
Bumps [requests](https://github.com/requests/requests) from 2.18.4 to 2.20.0. - [Release notes](https://github.com/requests/requests/releases) - [Changelog](https://github.com/psf/requests/blob/master/HISTORY.md) - [Commits](psf/requests@v2.18.4...v2.20.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.22 to 1.24.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/master/CHANGES.rst) - [Commits](urllib3/urllib3@1.22...1.24.2) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [flask](https://github.com/pallets/flask) from 0.12.2 to 1.0. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/master/CHANGES.rst) - [Commits](pallets/flask@0.12.2...1.0) Signed-off-by: dependabot[bot] <[email protected]>
Update huel.py
Update roll.py
…ask-1.0 Bump flask from 0.12.2 to 1.0
…llib3-1.24.2 Bump urllib3 from 1.22 to 1.24.2
…quests-2.20.0 Bump requests from 2.18.4 to 2.20.0
…rkzeug-0.15.3 Bump werkzeug from 0.14.1 to 0.15.3
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 0.15.3 to 0.16.0. - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/master/CHANGES.rst) - [Commits](pallets/werkzeug@0.15.3...0.16.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [requests](https://github.com/requests/requests) from 2.20.0 to 2.22.0. - [Release notes](https://github.com/requests/requests/releases) - [Changelog](https://github.com/psf/requests/blob/master/HISTORY.md) - [Commits](psf/requests@v2.20.0...v2.22.0) Signed-off-by: dependabot[bot] <[email protected]>
…equests-2.22.0 Bump requests from 2.20.0 to 2.22.0
…erkzeug-0.16.0 Bump werkzeug from 0.15.3 to 0.16.0
Roujo
force-pushed
the
feature/meme-rolls
branch
from
4bc41d6
to
c9c10b9
Compare
|
This will result in very heavy rolling sessions. I don't think I can approve this PR in its current form. |
|
Yeah, it would be rather heavy wouldn't it. I'll rework it so that only special numbers are output as memes. As an aside, there is work being done to make images created by the meme plugin collapsible, which would also help address this. All that would be left is the fact that they don't appear on mobile, which is still a blocking issue that I'll try to address somehow. ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.