Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wp3 storm surge #43

Merged
merged 18 commits into from
Sep 3, 2024
Merged

Wp3 storm surge #43

merged 18 commits into from
Sep 3, 2024

Conversation

mathvansoest
Copy link
Collaborator

Merge with main before creating pull request, no issues show up now.

@EtienneKras
Copy link
Collaborator

So, with this PR you tend to merge in two datasets: TWL & storm surge and wave climate.
Couple of comments:

  • could you check indentation? I see that the catalog.json file changes again nearly as a whole
  • also other files like cbca, ceed, etc. changed due to, I suspect, indentation. I only expect the newly added datasets collections to change and not the other collections. Could you check this as well?
  • As these sets are part of full-track WP3, could you add the following keywords to both collections for twl & ss_wc: "Sea Levels", "Full-Track"? This allows us to filter more efficiently
  • in ss_wc there is a validation error from pystac in the license. Please check if you can resolve this.

Cheers

EtienneKras
EtienneKras requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@EtienneKras EtienneKras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, nearly there I think

src/coclicodata/etl/cloud_utils.py Show resolved Hide resolved
scripts/utils/upload_and_generate_geojson.py Outdated Show resolved Hide resolved
scripts/utils/upload_and_generate_geojson.py Outdated Show resolved Hide resolved
current/twl/collection.json Show resolved Hide resolved
current/ss_wc/collection.json Show resolved Hide resolved
EtienneKras
EtienneKras reviewed Aug 7, 2024
View reviewed changes
scripts/utils/upload_and_generate_geojson.py Outdated Show resolved Hide resolved
scripts/utils/upload_and_generate_geojson.py Outdated Show resolved Hide resolved
notebooks/B01_epsg=3035_x=2366962_y=2138862.tif Outdated Show resolved Hide resolved
EtienneKras
EtienneKras reviewed Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@EtienneKras EtienneKras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments on the dataset formatting

current/ss_wc/SSp99-mapbox/SSp99-mapbox.json Outdated Show resolved Hide resolved
current/twl/RP1-mapbox/RP1-mapbox.json Outdated Show resolved Hide resolved
EtienneKras and others added 5 commits August 20, 2024 09:53
@EtienneKras
Update catalog
a6155fc 
Manually remove SLP pilot & GCTS 2000 collections & items (and catalog link for SLP pilot)
@mathvansoest
Added RP as dimension and fixed other issues
4d2bf3b
@mathvansoest
Changed 'values' -> 'twl', added 'locationId', changed RPx to float
1eb4e65
@mathvansoest
Had to change something in the code
751c2ca 
Dimcombs was outputting an empty dict in a list. This resulted in uwanted behaviour. Had to change the if statement. Not sure if correct, but its producing the right results.
@EtienneKras
Delete B01_epsg=3035_x=2366962_y=2138862.tif
c5e320f
EtienneKras
EtienneKras reviewed Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@EtienneKras EtienneKras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes in the PY files

scripts/create_stacs/19_ss_wc_stacs.py Outdated Show resolved Hide resolved
scripts/create_stacs/19_ss_wc_stacs.py Outdated Show resolved Hide resolved
scripts/create_stacs/19_ss_wc_stacs.py Show resolved Hide resolved
scripts/create_stacs/19_ss_wc_stacs.py Outdated Show resolved Hide resolved
@EtienneKras
Copy link
Collaborator

Adding SS_WC & TWL datasets

@EtienneKras EtienneKras merged commit f86ee62 into main Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneKras EtienneKras EtienneKras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathvansoest @EtienneKras