chore: fix broken tests for layer actions #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@florislangeraert can you also update Node / build here to 18? It should be okay. |
|
Kudos, SonarCloud Quality Gate passed!
|
Updated this to 18 in this branch. Also added support for all layer types:
|
scottbasgaard
commented
Oct 9, 2023
| @@ -1,8 +1,5 @@ | |||
| export function decorateLayerStyling(layerData) { | |||
| if ( | |||
| layerData.properties['deltares:source-layer'] && | |||
| layerData.properties['deltares:type'] === 'circle' | |||
There was a problem hiding this comment.
@florislangeraert I removed this test for type circle as the one you were testing was type symbol. Either way it should grab the paint styling directly over the API then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@florislangeraert fixed this to support async correctly.