fix(restore): set targetip on CVRs after restore is completed #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2020
mittachaitu
reviewed
Nov 5, 2020
|
@mittachaitu @mynktl I updated the PR, PTAL, thanks |
sonasingh46
reviewed
Nov 6, 2020
sonasingh46
reviewed
Nov 6, 2020
sonasingh46
reviewed
Nov 6, 2020
sonasingh46
reviewed
Nov 6, 2020
sonasingh46
reviewed
Nov 6, 2020
|
@zlymeda -- Thanks for the PR. Given some comments. |
|
@sonasingh46 regarding the DCO, I accepted two inline changes and those don't have my signoff in the message. Should I squeeze commits and force push? |
mittachaitu
reviewed
Nov 6, 2020
mynktl
approved these changes
Nov 9, 2020
|
I squeezed commits and force-pushed to fix the DCO. |
|
@zlymeda -- One last thing -- can you please rebase and then we can go ahead with the merge. |
Auto-setting of targetip on CVR if openebs.io/restore-completed is found Signed-off-by: Ondrej Belusky <[email protected]>
|
@sonasingh46 rebased |
shubham14bajpai
approved these changes
Nov 10, 2020
sonasingh46
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-setting of targetip on CVR if openebs.io/restore-completed is found
Pull Request template
Why is this PR required? What issue does it fix?:
Currently, users have to set targetip on CVRs after restore. Corresponding change in openebs/velero-plugin#131 will mark CVRs which needs to update the targetip. Changes in this PR will check the annotation and set the targetip.
What this PR does?:
Sets targetip on CVRs marked with openebs.io/restore-completed annotation.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
make testin velero-plugin repository with changes deployed.Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
related maya PR: openebs-archive/maya#1761
related velero-plugin PR: openebs/velero-plugin#131
Checklist:
<type>(<scope>): <subject>