Skip to content

Commit

Permalink
chore(ci): fix the formatting in pr template
Browse files Browse the repository at this point in the history
Signed-off-by: kmova <[email protected]>
  • Loading branch information
kmova committed Sep 11, 2021
1 parent e7b5eff commit 0f52386
Showing 1 changed file with 35 additions and 6 deletions.
41 changes: 35 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,29 @@
## Pull Request template
Please, go through these steps before you submit a PR.
**Why is this PR required? What issue does it fix?**:
_Fixes #<issue number>_

1. This repository follows semantic versioning convention, therefore each PR title/commit message must follow convention: `<type>(<scope>): <subject>`.
**What this PR does?**:

**Does this PR require any upgrade changes?**:

**If the changes in this PR are manually verified, list down the scenarios covered:**:

**Any additional information for your reviewer?** :
_Mention if this PR is part of any design or a continuation of previous PRs_


**Checklist:**
- [ ] PR Title follows the convention of `<type>(<scope>): <subject>`. <!-- See examples below. -->
- [ ] Has the change log section been updated?
- [ ] Commit has unit tests
- [ ] Commit has integration tests
- [ ] (Optional) Does this PR change require updating Helm Chart? If yes, mention the Helm Chart PR #<PR number>
- [ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
- [ ] (Optional) If documentation changes are required, which issue https://github.com/openebs/website is used to track them:

<!--
PR Title format.
This repository follows semantic versioning convention, therefore each PR title/commit message must follow convention: `<type>(<scope>): <subject>`.
`type` is defining if release will be triggering after merging submitted changes, details in [CONTRIBUTING.md](../CONTRIBUTING.md).
Most common types are:
* `feat` - for new features, not a new feature for build script
Expand All @@ -12,6 +34,13 @@ Please, go through these steps before you submit a PR.
* `test` - adding missing tests, refactoring tests; no production code change
* `refactor` - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
IMPORTANT: Please review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines.

**PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING**
Examples:
feat(ha): support faster node failure detection
fix(replica): remove previous replica with same ip
chore(build): upgrade the go version to 1.18
docs(user): add monitoring related user guides
refactor(provisoining): make use of the new context api
test(ut): handling volume deletion failures
test(integation): handling incorrect jiva images
test(e2e): running nfs on jiva volumes
-->

0 comments on commit 0f52386

Please sign in to comment.