Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replica/resize): api for resizing a replica #48

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat(replica/resize): api for resizing a replica #48

merged 1 commit into from
Dec 12, 2023

Conversation

dsharma-dc
Copy link
Contributor

No description provided.

niladrih
niladrih approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but still needs a second review IMO. Needs a rebase.

@dsharma-dc
Copy link
Contributor Author

@tiagolobocastro @Abhinandan-Purkait Apparently I'm not authorised to merge in this repo. Could you merge this please?
I'll sort out my permissions.

@Abhinandan-Purkait
Copy link
Member

@tiagolobocastro @Abhinandan-Purkait Apparently I'm not authorised to merge in this repo. Could you merge this please? I'll sort out my permissions.

Ohh seems like I too don't have any permissions on this repo.

@tiagolobocastro
Copy link
Contributor

tiagolobocastro commented Nov 29, 2023 •
edited
Loading

We're branching off develop soon (for release), so I'd say hold this up until then?

@dsharma-dc
Copy link
Contributor Author

dsharma-dc commented Nov 29, 2023 •
edited
Loading

We're branching off develop soon (for release), so I'd say hold this up until then?

@tiagolobocastro Sure, we can hold if that's what we've been following. Otherwise it's a harmless new protobuf so nothing breaking, and we can branch off the commits prior to this.

tiagolobocastro
tiagolobocastro approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linter, and remember not to merge until dataplane PR is approved.

@dsharma-dc dsharma-dc added the enhancement New feature or request label Dec 7, 2023
@dsharma-dc
Copy link
Contributor Author

Please fix linter, and remember not to merge until dataplane PR is approved.

linter fixed, PTAL at openebs/mayastor#1550

@dsharma-dc
Copy link
Contributor Author

@tiagolobocastro Could you please merge this if review on mayastor/1550 is complete.

@tiagolobocastro tiagolobocastro merged commit c2b4328 into develop Dec 12, 2023
3 checks passed
@tiagolobocastro tiagolobocastro deleted the repl_resz branch December 12, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@niladrih niladrih niladrih approved these changes

@abhilashshetty04 abhilashshetty04 abhilashshetty04 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsharma-dc @Abhinandan-Purkait @tiagolobocastro @niladrih @abhilashshetty04