Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(composer): allow setting 'host' network mode #96

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat(composer): allow setting 'host' network mode #96

merged 1 commit into from
Oct 25, 2024

Conversation

dsharma-dc
Copy link
Contributor

@dsharma-dc dsharma-dc commented Oct 1, 2024 •
edited
Loading

  • Allows to set network driver as 'host' in composer
  • Does not change anything in current behaviour as the current tests work without host network.
  • Has limitation at the moment that container will be returning grpc handle using loopback IP, hence creating more than one container on host network isn't safe.

Can be refined further as use case evolves.

@dsharma-dc dsharma-dc marked this pull request as ready for review October 10, 2024 08:25
tiagolobocastro
tiagolobocastro reviewed Oct 10, 2024
View reviewed changes
composer/src/composer.rs Outdated Show resolved Hide resolved
composer/src/composer.rs Show resolved Hide resolved
composer/src/composer.rs Show resolved Hide resolved
composer/src/composer.rs Outdated Show resolved Hide resolved
composer/src/composer.rs Outdated Show resolved Hide resolved
@dsharma-dc dsharma-dc force-pushed the host_nw_optional_ip branch 3 times, most recently from 1d7fb07 to 92997c7 Compare October 24, 2024 07:17
tiagolobocastro
tiagolobocastro approved these changes Oct 24, 2024
View reviewed changes
composer/src/composer.rs Outdated Show resolved Hide resolved
composer/src/composer.rs Outdated Show resolved Hide resolved
composer/src/composer.rs Show resolved Hide resolved
@dsharma-dc dsharma-dc mentioned this pull request Oct 24, 2024
Merged
@tiagolobocastro tiagolobocastro merged commit c895aac into develop Oct 25, 2024
5 checks passed
@tiagolobocastro tiagolobocastro deleted the host_nw_optional_ip branch October 25, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsharma-dc @tiagolobocastro @Abhinandan-Purkait