ci: add option to disable building of statically linked binaries #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
niladrih
force-pushed
the
dynamic-bins
branch
from
c4d0a0d to
7fdfb67
Compare
tiagolobocastro
approved these changes
Oct 17, 2024
Abhinandan-Purkait
approved these changes
Oct 17, 2024
Builds compile dependencies twice if binaries are built statically. Adding an option to disable static binary builds lets one build the binaries in the same cargo build as the rest of the Rust crates. This is useful when we're trying to save time building during integration tests. Signed-off-by: Niladri Halder <[email protected]>
niladrih
force-pushed
the
dynamic-bins
branch
from
7fdfb67 to
783fe70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds compile dependencies twice if binaries are built statically. Adding an option to disable static binary builds lets one build the binaries in the same cargo build as the rest of the Rust crates. This is useful when we're trying to save time building during integration tests.